Add new logger module #466

parfeon · 2025-09-15T23:02:03Z

feat(logger): add new logger module

Replace the legacy logger with the new logger module with a bundled console logger with a unified (with other SDKs) logs output format.

BREAKING CHANGES: Legacy logger removed and logging to file disabled by default.

feat(logger): provide interface for custom loggers

Provide interfaces for custom logger implementation.

feat(here-now): add limit and offset parameters

Add 'limit' and 'offset' parameters for 'PNHereNowRequest' for pagination support.

feat(retry-policy): retry policy moved to the network module

Retry policy can be applied for all API endpoint groups (not only subscribe).

refactor(deprecated): removed packetSizeForOperation

Removed previously deprecated packetSizeForOperation methods group along with size builder from the PubNub client.

refactor(deprecated): removed retry from status object

Removed previously deprecated retry and cancelAutomaticRetry methods along with the automaticallyRetry property from API processing status objects.

BREAKING CHANGES: To retry the last API call, same request object to the corresponding method.

refactor(deprecated): removed obsolete properties from status and result objects.

Removed previously deprecated properties: TLSEnabled, authKey, origin, userID, uuid, and statusCode.

BREAKING CHANGES: Most of the removed values can be retrieved from the client configuration, and the API processing HTTP status code was removed in favor of category fields.

refactor(deprecated): removed deprecated configuration options

Removed previously deprecated uuid, deviceID, applicationExtensionSharedGroupIdentifier, and completeRequestsBeforeSuspension configuration options.

BREAKING CHANGES: uuid has been removed in favor of the userID property.

Replace the legacy logger with the new logger module with a bundled console logger with a unified (with other SDKs) logs output format. BREAKING CHANGES: Legacy logger removed and logging to file disabled by default. feat(logger): provide interface for custom loggers Provide interfaces for custom logger implementation. feat(retry-policy): retry policy moved to the network module Retry policy can be applied for all API endpoint groups (not only `subscribe`). refactor(deprecated): removed `packetSizeForOperation` Removed previously deprecated `packetSizeForOperation` methods group along with `size` builder from the `PubNub` client. refactor(deprecated): removed `retry` from status object Removed previously deprecated `retry` and `cancelAutomaticRetry` methods along with the `automaticallyRetry` property from API processing status objects. BREAKING CHANGES: To retry the last API call, same request object to the corresponding method. refactor(deprecated): removed obsolete properties from `status` and `result` objects. Removed previously deprecated properties: `TLSEnabled`, `authKey`, `origin`, `userID`, `uuid`, and `statusCode`. BREAKING CHANGES: Most of the removed values can be retrieved from the client configuration, and the API processing HTTP status code was removed in favor of `category` fields. refactor(deprecated): removed deprecated configuration options Removed previously deprecated `uuid`, `deviceID`, `applicationExtensionSharedGroupIdentifier`, and `completeRequestsBeforeSuspension` configuration options. BREAKING CHANGES: `uuid` has been removed in favor of the `userID` property.

pubnub-ops-terraform · 2025-09-15T23:02:27Z

🎉 Snyk checks have passed. No issues have been found so far.

Add `limit` and `offset` parameters for `PNHereNowRequest` for pagination support.

Fix the issue where an immediate 'unsubscribe' after receiving a response from a subscription may cause a race condition where the next 'subscribe' is in the process of scheduling and can't be cancelled, causing 'leave' to time out. fix(cocoapods): address classes visibility Fix the issue because of which private classes leaked into public headers and the CocoaPod build failed.

jguz-pubnub · 2025-09-18T10:46:54Z

Package.swift

 //
 //  PubNub Real-time Cloud-Hosted Push API and Push Notification Client Frameworks
-//  Copyright (c) 2013 PubNub Inc.
+//  Copyright (c) 2013 PubNub Inc./Users/sergey/Documents/Develop/Objective-C/PubNub SDK (master)/PubNub.podspec


It seems that custom path has been accidentally inserted here

Good catch!

jguz-pubnub · 2025-09-18T10:49:28Z

Package.swift

-    .macOS(.v10_11),
-    .tvOS(.v10),
-    .watchOS(.v4)
+    .iOS(.v14),


I like that the deployment targets were increased, but I’m curious - was there a specific reason or change in this PR that required increasing them?

Actualize it with deployment targets in PubNub.podspec

jguz-pubnub · 2025-09-18T10:50:30Z

PubNub.podspec

It seems that deployment targets haven't been updated in the PubNub.podspec file as you did in Package.swift

But they are.. I didn't touch section in PubNub.podspec but now Package.swift finally has the same (after 2y I've finally synced Package.swift with PubNub.podspec).

jguz-pubnub · 2025-09-18T10:52:41Z

PubNub/Core/PubNub+ChannelGroup.m

 }

 - (void)channelsForGroup:(NSString *)group withCompletion:(PNGroupChannelsAuditCompletionBlock)block {
+    [self.logger warnWithLocation:@"PubNub" andMessageFactory:^PNLogEntry * {


Should we log deprecated method calls? The caller will already receive a warning message in the IDE (Xcode)

I was struggling with this decision. It is possible to silence any kind of IDE warnings in settings or during pod install in Podfile. If it is excessive, I'll remove it.

jguz-pubnub · 2025-09-18T10:56:16Z

PubNub/Core/PubNub+Subscribe.m

+        return [PNStringLogEntry entryWithMessage:@"Unsubscribe all channels and groups"];
+    }];
+
+    dispatch_queue_t queue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);


Why do we need dispatch_after here?

There were two approaches:

Update the transport interface to include functions that will handle race conditions.

Make a minimum delay to offset events in time (because there is no guarantee that the custom transport module will be properly implemented).

This code is present only in places where cancellation of the active subscription is done (in response to subscribe or unsubscribe method calls). The main issue is that unsubscribe (or presence leave) may time out because it is sent using the same transport (NSURLSession which allows only 1 concurrent request to the origin at a time) that is used for subscribe. The reason it happens is that the long-poll subscribe request could be sent earlier than leave which will cause a timeout (long-poll won't return in 10 seconds unless channels / groups are really active).

Issue reproducible when in subscribe / message status listener user will call unsubscribe.

jguz-pubnub · 2025-09-18T13:45:17Z

I have a general question: should we really add separate logs when a caller invokes a deprecated method? This occurs in many places, and the IDE should already provide a warning. I don't think this should be the logger mechanism's responsibility

parfeon self-assigned this Sep 15, 2025

parfeon requested a review from jguz-pubnub as a code owner September 15, 2025 23:02

parfeon added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. type: feature This PR contains new feature. type: refactor This PR contains refactored existing features. labels Sep 15, 2025

parfeon added 2 commits September 16, 2025 03:13

feat(here-now): add limit and offset parameters

cc1eeb2

Add `limit` and `offset` parameters for `PNHereNowRequest` for pagination support.

jguz-pubnub reviewed Sep 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add new logger module #466

Add new logger module #466

Uh oh!

parfeon commented Sep 15, 2025 •

edited

Loading

Uh oh!

pubnub-ops-terraform commented Sep 15, 2025 •

edited

Loading

Uh oh!

jguz-pubnub Sep 18, 2025

Uh oh!

parfeon Sep 22, 2025

Uh oh!

jguz-pubnub Sep 18, 2025 •

edited

Loading

Uh oh!

parfeon Sep 22, 2025

Uh oh!

jguz-pubnub Sep 18, 2025

Uh oh!

parfeon Sep 22, 2025

Uh oh!

jguz-pubnub Sep 18, 2025

Uh oh!

parfeon Sep 22, 2025

Uh oh!

jguz-pubnub Sep 18, 2025

Uh oh!

parfeon Sep 22, 2025

Uh oh!

jguz-pubnub commented Sep 18, 2025

Uh oh!

Uh oh!

Add new logger module #466

Are you sure you want to change the base?

Add new logger module #466

Uh oh!

Conversation

parfeon commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pubnub-ops-terraform commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jguz-pubnub Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jguz-pubnub commented Sep 18, 2025

Uh oh!

Uh oh!

parfeon commented Sep 15, 2025 •

edited

Loading

pubnub-ops-terraform commented Sep 15, 2025 •

edited

Loading

jguz-pubnub Sep 18, 2025 •

edited

Loading