Open
Conversation
Owner
|
Thanks! this is pretty big change with more than 100+ files. IT will take time to review properly |
mithereal
force-pushed
the
ash_oban
branch
6 times, most recently
from
4e3bdea to
c9a7c36
Compare
Owner
|
@mithereal hi, this PR is getting really big. Any chance we can split it? |
mithereal
force-pushed
the
ash_oban
branch
8 times, most recently
from
047d860 to
b81470a
Compare
fix cost calculations to deal with currency fix: sentry reporting fix sentry reporting add exception handling fix: order invoice fix order totals for pdf invoice fix: product price fix product price on create feat: add env vars in rel add env vars script to auto populate secrets when releasing a new fly.io app feat: inventory material type selector changed the material type selector to a reusable component feat: add demo mode added a demo mode to reset default passwords at timed interval fix: materials price change material price change defaulted to :USD feat: add material location input add an material location input feat: add default user add a startup job that ensures a default admin user exists fix: fix formatting for calorie amount calorie amount didnt follow formatting rules feat: add inventory location add inventory location feat: add sentry add sentry for error logging feat: currency setting change only allow currency rate settings change if currency converter is running fix: update migrations some of the migrations were broken, reinit and fix seeds feat: add ash oban added ash oban so when user changes system currency it will update currencies throughout the application
Contributor
Author
i squashed it into 1 pr i think +100 files are just migrations and snapshots, but im done with the pr now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added ash oban so when user changes system currency it will update currencies throughout the application.
in order to make this work with your existing data you can export to a csv and change the columns relating to price to use the custom field type ie {EUR, price}. modified schemas are listed in Craftplan.Settings.Changes.AssignCurrency, i did test and is working correctly.