feat: toggle database seeds via settings page#11
feat: toggle database seeds via settings page#11mithereal wants to merge 2 commits intopuemos:mainfrom
Conversation
add release seeder, add button in settings to seed demo data
config/runtime.exs
Outdated
|
|
||
| if System.get_env("PHX_SERVER") do | ||
| if System.get_env("PHX_SERVER") || | ||
| System.get_env("RAILWAY_PUBLIC_DOMAIN") do |
There was a problem hiding this comment.
let's try to avoid specific platforms names because if we don't this list will grow quickly
config/runtime.exs
Outdated
| host = System.get_env("HOST") || System.get_env("PHX_HOST") || "example.com" | ||
| host = | ||
| System.get_env("HOST") || System.get_env("PHX_HOST") || | ||
| System.get_env("RAILWAY_PUBLIC_DOMAIN") || |
There was a problem hiding this comment.
Same, avoid specific platform names
| {:open_api_spex, "~> 3.16"}, | ||
| {:req, "~> 0.5", only: [:dev, :test]} | ||
| {:req, "~> 0.5", only: [:dev, :test]}, | ||
| {:glific_phil_columns, github: "data-twister/phil_columns-ex"}, |
There was a problem hiding this comment.
I'd like to avoid using a library for that, can you bring this in-house or use a more stable and well known library?
There was a problem hiding this comment.
i switched to phil-columns bc its the best i know of that does seeding across multi files, i generally clone into this repo and use the forks in my projects so they dont dissapear, also i normally dont include the migrations and repo/resource_snapshots electing to use mix create during the deploy. just my pref.
| </section> | ||
| </div> | ||
| <section | ||
| id="forecasting-settings" |
| </section> | ||
|
|
||
| <section | ||
| id="forecasting-settings" |
|
Can we try to split this into PR per feature, there are a few combined. this will make it simpler to rollback if needed. I think one PR per fix + one PR for the seed system. |
split featureset into smaller chunks
2 participants
cleanup seeds, add button in settings to seed/delete demo data