This repository was archived by the owner on Nov 23, 2017. It is now read-only.
Add comment support at end of line#194
Open
cognominal wants to merge 2 commits intopuffnfresh:masterfrom
cognominal:comments
Open
Add comment support at end of line#194cognominal wants to merge 2 commits intopuffnfresh:masterfrom cognominal:comments
cognominal wants to merge 2 commits intopuffnfresh:masterfrom
cognominal:comments
Conversation
Unlike a whole comment line. A trailing comment does not appear in the javascript source. That should be fixable but less urgent
Author
|
This should fix #127 |
Collaborator
|
The problem here is that this tosses away the trailing comments entirely. The point of having comments in the grammar at all is so that we can capture them and put them back in the Javascript output. |
Author
|
Currently I use this for learning the language. In my code I comment out stuff that does not work yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike a whole comment line. A trailing comment does not appear in the
javascript source. That should be fixable but less urgent