-
Notifications
You must be signed in to change notification settings - Fork 16
Masking and Padding Functionality #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcelkant
wants to merge
62
commits into
pulp-platform:main
Choose a base branch
from
marcelkant:strided_mask_power_of_two
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
82fd85c
[feature] WIP Support arbitrary matrix shapes
Xeratec 7d07f84
[change] Speedup CI by removing Python Dependencies
Xeratec 2401587
Added debug.py to print matrices
f6d1100
Small changes in the debug.py file
c80f81f
Small changes in ita_controller.sv
d993c04
Started with the bias padding not finished yet
267850e
Bias padding solution with exactly 8 errors for each phase
8534850
Added additional buffer for bias values
08fa963
No buffering in the controller
abf4d18
Changed count_q foto (count_q-1) for the bias padding
fd7ae83
Added waves
22e835c
Added ctrl.ff_size for feedforward layer
64732e4
Bias padding works now but with quick fix
8f0d19a
count_q - 1 solution works for one tile
3c6040c
This version works for data_S127_E50_P64_F64_H1_B1 but not for data_S…
0094c11
No ebugs for bias padding detected one bug without bias in phase 5
2a04d89
Just errors in phase 5 and 6
aab0df5
No bugs in all phases
64978c1
Bias padding for all phases without bugs
d433625
Added test vectors in the gitlab-ci
8d4de04
Fixes in gitlab-ci
55ac726
Added license on top sim_ita_tb_wave_important.tcl
bf27488
Pipelining test
83290ae
Changed bias for test vectors in gitlab-ci
3db2ff7
Fixed synthesize errors
0ec7089
Fixed synthesize error
510b243
Started to add the triangular mask logic
3a61237
Upper triangular mask works for one tile
980a755
Test for multiple tiles
0109e78
This version works for one tile
f0a1605
Simulation error
457266c
Fixed simulation error
b7a2554
Pipelined step_q
3063d62
Changing the branch to adapt the golden model
c06cfa2
Changed the softmac function in the golden model
1c71277
Error in golden model
966e7d6
Errors in streamingPartialSoftmax function not solved
4bd29e3
Only four wrong values for 1 tile
07771e9
Four errors left for one tile
557ac19
Still searching for the reason for the four errors
b267458
Started to add the logic for more than one tile
d0ccc19
Works for two tiles but only with index smaller than 64
6d5c804
Test with s=511
b9bd447
Works now for multiple tiles but not extensively tested yet
2841115
Upper triangular mask works for multiple tiles
5612e8d
All triangular mask shapes work
b3068b1
Added functionality for the strided mask but not tested yet
9dbbd8e
Made new masking module
27a0e37
Added more masks in the golden model
343b6a9
Added upper and lower strided masks
b18f1d8
Added the strided sliding window mask but not working yet
a915d5b
Changes for automated tests
b400e51
Tested and synthesized
e38cd36
hwpe tb setup script with masking
Ludi-1 2443aee
mask working in hwpe tb
Ludi-1 ca34e72
clean up code and repo
Ludi-1 f2b8232
clean up whitespace
Ludi-1 8e01074
run script to cmd mode
Ludi-1 c11c5b2
Merge pull request #1 from Ludi-1/strided_mask_power_of_two
Ludi-1 105f448
Merge branch 'main' into strided_mask_power_of_two
Ludi-1 399455c
update softmax shift parameter
Ludi-1 c1861c1
clean sim
Ludi-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ | |
| "-S${input:seq_len}", | ||
| "-E${input:emb_len}", | ||
| "-P${input:prj_len}", | ||
| "--no-bias" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change shouldn't be required |
||
| ], | ||
| } | ||
| ], | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was this removed? By mistake? |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
--skip-vector-validationrequired for all?