-
Notifications
You must be signed in to change notification settings - Fork 8
doc: Contribution Guidelines #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Lore0599
wants to merge
1
commit into
pulp-platform:main
Choose a base branch
from
Lore0599:lleone/contribution-section
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Contribution guidelines | ||
|
|
||
| Thank you for your interest in contributing to this project! | ||
| We welcome external contributions and aim to make the process as smooth as possible. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. **Fork the repository**<br> | ||
| Please begin by creating a public fork of the repository on your own GitHub account. | ||
| We disabled the creation of branches on the upstream repository for all users to prevent that stale branches are left hanging around. | ||
|
|
||
| 2. **Enable the CI on your fork**<br> | ||
| Enable Github Actions on your fork to run the CI. | ||
| This will run a broader set of jobs than the PR-triggered CI, which require permissions on the repo's cache and container registry. | ||
| The maintainers will check your fork's CI to validate your PR. | ||
|
|
||
| 3. **Open a PR to `devel`**<br> | ||
| Once your changes are ready, open a PR targeting the `devel` branch (**not** `main`). | ||
| If your contributions are still a work-in-progress, e.g. some of the CI checks on your fork are still failing, please open the PR as a draft. | ||
| Once your PR is merged into `devel`, additional CI jobs will run on our internal servers, with access to commercial licenses and proprietary tools. | ||
| The maintainers will take care of any issues, and push the contributions to `main` once all issues are fixed. | ||
|
|
||
| ## Communication | ||
|
|
||
| If you're planning a larger contribution or need clarification, feel free to open an issue. We're happy to help guide you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lore0599 typo?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielKellerM Yes I'm using this PR as a test to see if I can trigger the CI in PR coming from forks, sorry I forget to set the PR as a draft