Move package imports to module scope #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import packages into the compilation unit scope (meaning you put the import before the module declaration) is very bad practice. Depending on the tool (whether it puts every file into one single compilation unit or every file in its own compilation unit), it causes imported symbols with identical name to be overriden. E.g. this module's .* imports clash with the imports in the hwpe-mac-engine IP. Instead the import should happen after the module name declaration before the parameter list. That way, the import is scoped to the module.