Skip to content

Use build instead of deprecated setup.py #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggainey merged 1 commit into from
Oct 21, 2025
Merged

Use build instead of deprecated setup.py #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/github/.github/workflows/scripts/build_python_client.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ rm -rf "{{ plugin.name | snake }}-client"
./gen-client.sh "../{{ plugin_name }}/{{ plugin.app_label }}-api.json" "{{ plugin.app_label }}" python "{{ plugin.name | snake }}"

pushd {{ plugin.name | snake }}-client
python setup.py sdist bdist_wheel --python-tag py3
python -m build

twine check "dist/{{ plugin.name | snake }}_client-"*"-py3-none-any.whl"
twine check "dist/{{ plugin.name | snake }}_client-"*".tar.gz"
Expand Down
2 changes: 1 addition & 1 deletion templates/github/.github/workflows/scripts/publish_client_pypi.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ fi
twine upload -u __token__ -p "${PYPI_API_TOKEN}" \
{%- for plugin in plugins %}
"dist/{{ plugin.name | snake }}_client-${VERSION}-py3-none-any.whl" \
"dist/{{ plugin.name | snake }}-client-${VERSION}.tar.gz" \
"dist/{{ plugin.name | snake }}_client-${VERSION}.tar.gz" \
{%- endfor %}
;
2 changes: 1 addition & 1 deletion templates/github/.github/workflows/scripts/script.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ pushd ../pulp-openapi-generator
rm -rf "./${PACKAGE}-client"
./gen-client.sh "${COMPONENT}-api.json" "${COMPONENT}" python "${PACKAGE}"
pushd "${PACKAGE}-client"
python setup.py sdist bdist_wheel --python-tag py3
python -m build
popd
else
if [ ! -f "${PACKAGE}-client/dist/${PACKAGE}_client-${VERSION}-py3-none-any.whl" ]
Expand Down
2 changes: 1 addition & 1 deletion templates/github/.github/workflows/test.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
{%- endfor %}
{%- endif %}

{{ install_python_deps(["towncrier", "twine", "wheel", "httpie", "docker", "netaddr", "boto3", "ansible~=10.3.0", "mkdocs", "jq", "jsonpatch", "bump-my-version", "click<8.3"]) | indent(6) }}
{{ install_python_deps(["build", "towncrier", "twine", "wheel", "httpie", "docker", "netaddr", "boto3", "ansible~=10.3.0", "mkdocs", "jq", "jsonpatch", "bump-my-version", "click<8.3"]) | indent(6) }}

{{ setup_env() | indent(6) }}

Expand Down