[PULP-741] Pydantic improvements #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@pedro-psb This would be my attempt at "solving" the oneOf. |
mdellweg
force-pushed
the
pydantic_improvements
branch
from
f460fd0 to
0d4149a
Compare
pedro-psb
requested changes
Aug 18, 2025
Member
pedro-psb
left a comment
pedro-psb
left a comment
There was a problem hiding this comment.
I don't have the openapi-spec/oa-gen/pydantic expertise to tell if it would really behave as intended, but it's promissing.
I guess we can try it out if it passes basic tests. Can you add a test matrix to exercise all ranges? <3.70, >=3.70,<3.85 and >=3.85,<3.100. Or if you prefer, doing a manual test against 3.85 should be enough evidence.
mdellweg
force-pushed
the
pydantic_improvements
branch
from
0d4149a to
9a8067f
Compare
mdellweg
force-pushed
the
pydantic_improvements
branch
from
9a8067f to
2f5697e
Compare
pedro-psb
approved these changes
Sep 3, 2025
Member
pedro-psb
left a comment
pedro-psb
left a comment
There was a problem hiding this comment.
The test PR is two week by now, but it went fine and I'm confident no major bind-wise thing changed since then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.