Add include/exclude filter support for pull-through caching#747
Add include/exclude filter support for pull-through caching#747
Conversation
gerrod3
force-pushed
the
pull-through-filters
branch
from
e9a4c7a to
375bf2f
Compare
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
|
This pull request is no longer marked for closure. |
gerrod3
force-pushed
the
pull-through-filters
branch
3 times, most recently
from
54cdf1b to
f7f6068
Compare
gerrod3
force-pushed
the
pull-through-filters
branch
4 times, most recently
from
89415ed to
11a9083
Compare
| if d.headers["content-type"] == "application/vnd.pypi.simple.v1+json": | ||
| page = ProjectPage.from_json_data(json.load(open(d.path, "rb")), base_url=remote.url) | ||
| else: | ||
| page = ProjectPage.from_html(package, open(d.path, "rb").read(), base_url=remote.url) |
There was a problem hiding this comment.
Not requesting a change, just a question:
Are JSON responses from the simple API a recent addition? How could it be HTML or JSON?
There was a problem hiding this comment.
Yep new PEP: https://peps.python.org/pep-0691/. The accept headers specify that we accept both the json + html (normal) response with a preference for the new json format.
There was a problem hiding this comment.
Cool, that's an improvement tbh.
gerrod3
force-pushed
the
pull-through-filters
branch
from
11a9083 to
5a91413
Compare
gerrod3
force-pushed
the
pull-through-filters
branch
from
5a91413 to
fc82100
Compare
2 participants
wip