Rewrite metadata extraction function to take in a file object#941
Merged
Rewrite metadata extraction function to take in a file object#941
Conversation
gerrod3
force-pushed
the
md-util-rewrite
branch
from
952bfdc to
20b1654
Compare
jobselko
approved these changes
Aug 19, 2025
Contributor
jobselko
left a comment
jobselko
left a comment
There was a problem hiding this comment.
Thank you! I think we can merge this, wdyt?
jobselko
reviewed
Aug 19, 2025
gerrod3
force-pushed
the
md-util-rewrite
branch
from
20b1654 to
68dd933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jobselko I was looking at the rpm sync-upload code and realized we could also extract the metadata from the file without converting it to an artifact first. Maybe this could help simplify your implementation.