[PULP-715] Add JSON-based Simple API by jobselko · Pull Request #956 · pulp/pulp_python

jobselko · 2025-09-04T20:31:08Z

closes #625

gerrod3

This PR looks like it is coming along well.

pulp_python/tests/functional/api/test_pypi_simple_json_api.py

pulp_python/app/pypi/views.py

pulp_python/app/utils.py

gerrod3

Couple changes left.

pulp_python/app/models.py

pulp_python/app/utils.py

pulp_python/app/tasks/publish.py

pulp_python/app/pypi/views.py

pulp_python/app/utils.py

dralley · 2025-10-31T16:48:52Z

pulp_python/app/models.py

    python_version = models.TextField()
    sha256 = models.CharField(db_index=True, max_length=64)
+    sha256_metadata = models.CharField(max_length=64)
+    yanked = models.BooleanField(default=False)


@gerrod3 So, I take it that the python plugin does not have "immutable" content, since "yanked" is explicitly mutable?

The yanked attribute is not immutable once set, and may be rescinded in the future (and once rescinded, may be reset as well). Thus API users MUST be able to cope with a yanked file being “unyanked” (and even yanked again).

Yeah I don't know what to do with the field. I decided to originally not implement it since it's mutable and only useful per repository. Maybe we can do something similar to pulp_ansible and add a new yanked content type that's presence in the repository tells us the content should be yanked. For now let's remove the field and deal with it later.

pulp_python/tests/functional/api/test_pypi_simple_json_api.py

gerrod3

Wow, great work! Thank you @jobselko 🎉

pulp_python/app/pypi/views.py

pulp_python/app/utils.py

closes pulp#625

jobselko self-assigned this Sep 4, 2025

github-actions bot added no-changelog multi-commit Add to bypass single commit lint check no-issue labels Sep 4, 2025

jobselko force-pushed the close_625 branch 2 times, most recently from 16f7486 to 03e61c7 Compare September 8, 2025 21:52

github-actions bot removed the multi-commit Add to bypass single commit lint check label Sep 8, 2025

jobselko force-pushed the close_625 branch 2 times, most recently from c7e19ec to 6647217 Compare September 8, 2025 22:06

gerrod3 reviewed Sep 14, 2025

View reviewed changes

jobselko force-pushed the close_625 branch 5 times, most recently from 5ad38d9 to 597818e Compare September 24, 2025 09:02

gerrod3 requested changes Oct 27, 2025

View reviewed changes

dralley reviewed Oct 30, 2025

View reviewed changes

pulp_python/app/utils.py Outdated Show resolved Hide resolved

dralley reviewed Oct 31, 2025

View reviewed changes

jobselko force-pushed the close_625 branch from 597818e to b8af421 Compare November 3, 2025 13:29

github-actions bot added the multi-commit Add to bypass single commit lint check label Nov 3, 2025

jobselko force-pushed the close_625 branch 5 times, most recently from ed76616 to fff96d2 Compare November 4, 2025 07:39

github-actions bot removed the multi-commit Add to bypass single commit lint check label Nov 4, 2025

jobselko force-pushed the close_625 branch 2 times, most recently from 546e0ad to b0d5dc8 Compare November 4, 2025 16:00

github-actions bot added the multi-commit Add to bypass single commit lint check label Nov 4, 2025

jobselko force-pushed the close_625 branch from b0d5dc8 to 1ce6588 Compare November 4, 2025 20:49

jobselko force-pushed the close_625 branch 8 times, most recently from e113dee to 9b0c4b3 Compare November 5, 2025 22:29

jobselko commented Nov 5, 2025

View reviewed changes

pulp_python/tests/functional/api/test_pypi_simple_json_api.py Show resolved Hide resolved

jobselko force-pushed the close_625 branch 2 times, most recently from 7812757 to 7916e65 Compare November 5, 2025 22:58

github-actions bot added multi-commit Add to bypass single commit lint check and removed multi-commit Add to bypass single commit lint check labels Nov 5, 2025

jobselko force-pushed the close_625 branch from a3313fb to eb8e0ca Compare November 6, 2025 12:54

github-actions bot removed multi-commit Add to bypass single commit lint check no-issue labels Nov 6, 2025

jobselko force-pushed the close_625 branch from eb8e0ca to 4f494d3 Compare November 6, 2025 13:02

github-actions bot removed the no-changelog label Nov 6, 2025

jobselko requested review from dralley and gerrod3 November 6, 2025 13:26

gerrod3 approved these changes Nov 6, 2025

View reviewed changes

dralley reviewed Nov 6, 2025

View reviewed changes

pulp_python/app/pypi/views.py Outdated Show resolved Hide resolved

dralley reviewed Nov 6, 2025

View reviewed changes

pulp_python/app/utils.py Outdated Show resolved Hide resolved

dralley reviewed Nov 6, 2025

View reviewed changes

pulp_python/app/utils.py Show resolved Hide resolved

dralley reviewed Nov 6, 2025

View reviewed changes

pulp_python/app/utils.py Show resolved Hide resolved

jobselko force-pushed the close_625 branch from 4f494d3 to 9dbbbe4 Compare November 6, 2025 21:06

Add JSON-based Simple API

52db037

closes pulp#625

jobselko force-pushed the close_625 branch from 9dbbbe4 to 52db037 Compare November 6, 2025 21:28

dralley approved these changes Nov 6, 2025

View reviewed changes

dralley merged commit c08fcb2 into pulp:main Nov 6, 2025
13 checks passed

Conversation

jobselko commented Sep 4, 2025

Uh oh!

gerrod3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gerrod3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dralley Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

gerrod3 Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gerrod3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants