[PULP-277] Adapt to 'CONTENT_ORIGIN can be null'.#3865

Merged

ggainey merged 1 commit intopulp:mainfrom

ggainey:3856_null_origin

Feb 13, 2025

Contributor

ggainey commented Jan 22, 2025

fixes #3856.

github-actions bot added the no-changelog label

ggainey force-pushed the 3856_null_origin branch 5 times, most recently from c966438 to 989f86a Compare

January 24, 2025 21:08

Contributor Author

ggainey commented Jan 24, 2025

Once pulp/pulpcore#6175 merges I'll remove the temporary distribution_base_url fixture and undraft.

ggainey commented

View reviewed changes

pulp_rpm/tests/functional/content_handler/test_config_repo.py Show resolved Hide resolved

ggainey force-pushed the 3856_null_origin branch from 989f86a to ae4941d Compare

January 31, 2025 02:31

ggainey marked this pull request as ready for review

January 31, 2025 02:32

ggainey requested review from dralley and pedro-psb

January 31, 2025 02:32

pedro-psb reviewed

View reviewed changes

pulp_rpm/app/models/repository.py Show resolved Hide resolved

pedro-psb reviewed

View reviewed changes

pulp_rpm/tests/functional/api/test_sync.py Show resolved Hide resolved

pedro-psb reviewed

View reviewed changes

pulp_rpm/tests/functional/content_handler/test_config_repo.py Outdated Show resolved Hide resolved

pedro-psb reviewed

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

pedro-psb reviewed

View reviewed changes

Member

pedro-psb left a comment

@dralley I've added a few comments.

About the pulp_smash test removals, were they redundant? Do we need to recreate them without smash?

dralley approved these changes

View reviewed changes

pedro-psb mentioned this pull request

Core 3.70 compatibility #3876

Merged

ggainey force-pushed the 3856_null_origin branch from ae4941d to c12792a Compare

February 9, 2025 19:19

ggainey requested a review from pedro-psb

February 9, 2025 19:20

ggainey force-pushed the 3856_null_origin branch from c12792a to 1b6d6b7 Compare

February 9, 2025 21:00

github-actions bot removed the no-changelog label

Contributor Author

ggainey commented Feb 10, 2025

@dralley I've added a few comments.

About the pulp_smash test removals, were they redundant? Do we need to recreate them without smash?

Those tests were written (I believe) to test a specific problem involving a specific upgrade path a Long Time Ago. They haven't ever actually run, either locally or via CI, since they were added. We have tests for publishing. So I think we're good.

Contributor

dralley commented Feb 10, 2025

Correct we discussed that in the meeting

Currently this PR is waiting on #3876 FYI

ggainey force-pushed the 3856_null_origin branch from 1b6d6b7 to a4a4ca2 Compare

February 12, 2025 18:14

github-actions bot added the no-changelog label

ggainey marked this pull request as draft

February 12, 2025 18:39

ggainey force-pushed the 3856_null_origin branch from a4a4ca2 to 02dee79 Compare

February 13, 2025 01:55

github-actions bot removed the no-changelog label

ggainey force-pushed the 3856_null_origin branch from 02dee79 to b321261 Compare

February 13, 2025 03:55


          [PULP-277] Adapt to 'CONTENT_ORIGIN can be null'.

452f43d

Removed tests/upgrade directory - these tests don't test anything
current, and have not actually been run in years.

fixes pulp#3856.

ggainey force-pushed the 3856_null_origin branch from b321261 to 452f43d Compare

February 13, 2025 04:09

ggainey marked this pull request as ready for review

February 13, 2025 12:56

pedro-psb approved these changes

View reviewed changes

Member

pedro-psb left a comment

LGTM

ggainey merged commit f2dd93b into pulp:main

12 checks passed

ggainey deleted the 3856_null_origin branch

December 15, 2025 14:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet