Skip to content

Conversation

@vycius
Copy link
Contributor

@vycius vycius commented Jan 18, 2026

Introduce RemoteNetworkConfigSerializer to centralize shared network settings (timeouts, proxies, and certificates) and ensure consistent validation across persistent Remotes and ad-hoc upload downloads.

  • Exclude sync-specific fields (policy, rate_limit) from shared config
  • Pass validated network kwargs to the downloader in UploadSerializerFieldsMixin
  • Reuse common proxy and certificate validation logic

closes: #7201

@vycius vycius force-pushed the 7201-support-timeout-customization-for-sync-file-upload branch from 50e31fd to 26f39f5 Compare January 18, 2026 15:28
@vycius vycius changed the title Add network configuration support for synchronous file uploads WIP: Add network configuration support for synchronous file uploads Jan 18, 2026
@vycius vycius force-pushed the 7201-support-timeout-customization-for-sync-file-upload branch from 26f39f5 to 5719167 Compare January 23, 2026 16:18
@github-actions github-actions bot removed the no-issue label Jan 23, 2026
@vycius vycius force-pushed the 7201-support-timeout-customization-for-sync-file-upload branch 3 times, most recently from 218e42f to a5e6bfd Compare January 24, 2026 08:46
@vycius vycius changed the title WIP: Add network configuration support for synchronous file uploads Add network configuration support for synchronous file uploads Jan 24, 2026
@vycius vycius requested a review from pedro-psb January 24, 2026 09:40
@vycius
Copy link
Contributor Author

vycius commented Jan 24, 2026

@pedro-psb Thanks for the feedback. Pull request is ready for review.

@vycius vycius force-pushed the 7201-support-timeout-customization-for-sync-file-upload branch from a5e6bfd to eced14f Compare January 24, 2026 09:43
@vycius vycius force-pushed the 7201-support-timeout-customization-for-sync-file-upload branch from eced14f to 8ce9727 Compare January 31, 2026 08:43
@vycius vycius force-pushed the 7201-support-timeout-customization-for-sync-file-upload branch 2 times, most recently from 35ed195 to ddf4ad7 Compare January 31, 2026 09:56
@vycius vycius force-pushed the 7201-support-timeout-customization-for-sync-file-upload branch from ddf4ad7 to 3548a73 Compare January 31, 2026 09:59
Introduce RemoteNetworkConfigSerializer to centralize shared network
settings (timeouts, proxies, and certificates) and ensure consistent
validation across persistent Remotes and ad-hoc upload downloads.

- Exclude sync-specific fields (policy, rate_limit) from shared config
- Pass validated network kwargs to the downloader in UploadSerializerFieldsMixin
- Reuse common proxy and certificate validation logic

closes: pulp#7201
@vycius vycius force-pushed the 7201-support-timeout-customization-for-sync-file-upload branch from 3548a73 to 2e43dc4 Compare January 31, 2026 10:30
@vycius vycius requested a review from pedro-psb January 31, 2026 11:50
Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@pedro-psb pedro-psb merged commit bdc11f2 into pulp:main Feb 3, 2026
13 checks passed
@vycius vycius deleted the 7201-support-timeout-customization-for-sync-file-upload branch February 3, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support timeout customization for synchronous File upload API

2 participants