-
Notifications
You must be signed in to change notification settings - Fork 256
Improve getting started experience #16065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Review SummaryThis PR adds a new getting started experience across 4 cloud providers. The content is well-structured and comprehensive, but there are several issues that need to be addressed before merging. Issues FoundCritical IssuesMissing newlines at end of files (Lines: EOF)
This violates the absolute prohibition in AGENTS.md: "New files: Must always end with a newline." Style Guide ViolationsHeading capitalization issues
Semantic line break violations
Content IssuesLanguage consistency
Link verification needed
Technical AccuracyCode examples Command sequences Positive Aspects
Recommendations
The content quality is high and the structure is excellent. Once the style guide violations are addressed, this will be a valuable addition to the getting started experience. |
Your site preview for commit 71ad0f9e is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16065-71ad0f9e.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit f39fc5f is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16065-f39fc5fc.s3-website.us-west-2.amazonaws.com. |
Asaf mind adding a PR description explaining what change we are making? Is Joe the only reviewer we want? |
No description provided.