Skip to content

fix(window): high-DPI scaling + tighten Settings/About spacing (#238) #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lshw54 merged 3 commits into from
Apr 26, 2026
+19 −5
Merged

fix(window): high-DPI scaling + tighten Settings/About spacing (#238) #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb70a25
fix(window): cap fitWindow height to 80% of screen for high-DPI displ…
lshw54 Apr 26, 2026
74d0620
fix(window): cap fitWindow to 80% screen height + tighten Settings sp…
lshw54 Apr 26, 2026
99da378
chore(about): add lshw54 to credits + tighten About scroll padding
lshw54 Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/pages/About.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ onMounted(() => {
<div class="about__header-text">
<div class="about__title-row">
<h1 class="about__title bf-text-gradient">{{ t('AppName') }}</h1>
<span class="about__author">By Pungin and YCC3741</span>
<span class="about__author">By Pungin, YCC3741 and lshw54</span>
</div>
<p class="about__version-row" data-test="about-version-row">
<span>{{ t('Version') }}</span>
Expand Down Expand Up @@ -319,6 +319,15 @@ onMounted(() => {
<el-icon><Message /></el-icon>
<span>YCC3741</span>
</a>
<a
href="#"
class="about__contact-link"
data-test="about-email-lshw54"
@click.prevent="handleEmail('lshw.5454@gmail.com')"
>
<el-icon><Message /></el-icon>
<span>lshw54</span>
</a>
<a
href="#"
class="about__contact-link"
Expand Down Expand Up @@ -357,7 +366,7 @@ onMounted(() => {
.about__scroll {
flex: 1;
overflow-y: auto;
padding: 1.5rem;
padding: 1rem 1.5rem;
}

.about__container {
Expand Down
4 changes: 2 additions & 2 deletions src/pages/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,14 +906,14 @@ onMounted(() => {
.settings__scroll {
flex: 1;
overflow-y: auto;
padding: 1.5rem;
padding: 1rem 1.5rem;
}

.settings__container {
width: 100%;
display: flex;
flex-direction: column;
gap: 1rem;
gap: 0.75rem;
}

/* --------------- header --------------- */
Expand Down
7 changes: 6 additions & 1 deletion src/router/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,12 @@ export function installRouterGuards(router: Router, deps: RouterGuardDeps): void
function maxFitHeight(): number {
const avail = typeof window !== 'undefined' ? window.screen?.availHeight : undefined
if (typeof avail === 'number' && avail > 0) {
return Math.max(300, avail - 50)
// Reserve space for the Windows taskbar + some breathing room.
// On high-DPI displays (125%/150%), availHeight is already in
// CSS pixels but the effective usable area is smaller because
// the OS reserves more physical pixels for chrome. Using 80%
// of availHeight ensures the window never clips off-screen.
return Math.max(300, Math.floor(avail * 0.8))
}
return 900
}
Expand Down