(PE-42492) Use dnf on fedora >= 41 #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 29, 2025
| # any other type of source means we use a package manager (yum) with no 'source' parameter in the | ||
| # package resource below | ||
| $_package_version = $package_version | ||
| $_provider = 'yum' |
There was a problem hiding this comment.
Do we even have to set the provider? Can't we use undef?
There was a problem hiding this comment.
Leaving it unspecified makes sense in general.. but it's been this way for so long, I didn't want to break anything. This is especially true because when doing an agent upgrade from 6.x to 8.x, we run the 6.x version of the provider to perform the upgrade. If we switch to dnf, then we have to be sure dnf in puppet 6.x works when upgrading to 8.x.
There was a problem hiding this comment.
I'd be fine using undef for fedora 41 and up. It doesn't work now, so no harm in changing it.
joshcooper
force-pushed
the
fedora41
branch
from
2bbcc1d to
5aeb35c
Compare
On Fedora 41, `yum` is a symlink to dnf5, which doesn't accept -d:
Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y update puppet-agent-8.15.0.9.g6d2fce25b' returned 2: Unknown argument "-d" for command "dnf5". Add "--help" for more information about the arguments.
Puppet's dnf provider was updated to support dnf5 in PA-7414, see
puppetlabs/puppet-private@0d932d327ef, but that doesn't help if the provider is
explicitly set to `yum`.
joshcooper
force-pushed
the
fedora41
branch
from
5aeb35c to
2e06fd2
Compare
puppetlabs/puppetlabs-inifile@64aaa08#diff-009cf0f832b3fccfa64213c7b2d0fb136df78deec09ac2a21b6d86d729ef3436R63 causes puppet_agent specs to fail on ruby 2.7: Evaluation Error: Error while evaluating a Resource Statement, Could not autoload puppet/type/ini_setting: /Users/runner/work/puppetlabs-puppet_agent/puppetlabs-puppet_agent/spec/fixtures/modules/inifile/lib/puppet/type/ini_setting.rb:63: syntax error, unexpected '}' ..., not '%{value}'") % { value: }) unless Puppet::Util.absolut... For now, pin to the most recently released version.
joshcooper
force-pushed
the
fedora41
branch
from
2e06fd2 to
44234af
Compare
cthorn42
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Fedora 41,
yumis a symlink to dnf5, which doesn't accept -d:Puppet's dnf provider was updated to support dnf5 in PA-7414, see puppetlabs/puppet-private@0d932d327ef, but that doesn't help if the provider is explicitly set to
yum.