Skip to content

(SUP-5232) Added error handling to JSON conversion of metrics #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

(SUP-5232) Added error handling to JSON conversion of metrics #202

merged 1 commit into from
Jan 7, 2025

Conversation

Rory-Johnston
Copy link
Contributor

  • Added error handling for converting the metrics to a JSON object
  • Outputs the error message for easier debugging and maintenance

@Rory-Johnston Rory-Johnston added the enhancement New feature or request label Jan 6, 2025
@Rory-Johnston Rory-Johnston requested a review from a team as a code owner January 6, 2025 14:19
@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

MartyEwings
MartyEwings approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MartyEwings MartyEwings merged commit ffd12b7 into puppetlabs:main Jan 7, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartyEwings MartyEwings MartyEwings approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rory-Johnston @CLAassistant @MartyEwings