Skip to content

(PE-40346) Fix retrieve_additional_metrics error handling #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

(PE-40346) Fix retrieve_additional_metrics error handling #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2cd0fa
Revert "(SUP-5232) Added error handling to JSON conversion of metrics"
Sharpie Feb 12, 2025
137a00c
(PE-40346) Ensure additional_metrics requests return Array
Sharpie Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions files/pe_metrics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,16 +79,16 @@ def post_endpoint(url, body)
end

def retrieve_additional_metrics(url, _metrics_type, metrics)
begin
json_data = metrics.to_json
rescue StandardError => e
STDERR.puts 'Failed to convert metrics to JSON.'
STDERR.puts "Error: #{e.message}"
STDERR.puts e.backtrace
metrics_output = post_endpoint(url, metrics.to_json)

unless metrics_output.is_a?(Array)
STDERR.puts('ERROR request to %{url} returned data non-Array data of type %{class}: %{output}' %
{ url: url,
class: metrics_output.class,
output: metrics_output.to_s })
return []
end

metrics_output = post_endpoint(url, json_data)
return [] if metrics_output.empty?

# For a status other than 200 or 404, add the HTTP code to the error array
Expand Down
Loading