Skip to content

Fix performance issue in 'allDependencies' #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomashoneyman merged 1 commit into from
Nov 9, 2023
Merged

Fix performance issue in 'allDependencies' #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/src/App/API.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,10 +625,7 @@ publish source payload = do
let sourceModules = Map.keys $ Map.filter (isJust <<< String.stripPrefix (String.Pattern packageDirectory) <<< _.path) graph

Log.debug "Found all modules used in package source. Finding all modules used by those modules..."
-- We find all dependencies of each module used in the source,
-- which results in a set containing every module name reachable
-- by the source code.
let allReachableModules = Set.fromFoldable $ Array.fold $ Array.mapMaybe (flip PursGraph.allDependencies graph) $ Set.toUnfoldable sourceModules
let allReachableModules = PursGraph.allDependenciesOf sourceModules graph

-- Then we can associate each reachable module with its package
-- name to get the full set of used package names.
Expand Down
2 changes: 1 addition & 1 deletion app/src/App/Legacy/Manifest.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ fetchLegacyManifest
fetchLegacyManifest name address ref = Run.Except.runExceptAt _legacyManifestError do
legacyPackageSets <- fetchLegacyPackageSets >>= case _ of
Left error -> do
Log.error $ "Failed error when to fetch legacy package sets: " <> Octokit.printGitHubError error
Log.error $ "Failed to fetch legacy package sets: " <> Octokit.printGitHubError error
Except.throw "Could not retrieve legacy package sets; aborting to avoid producing incorrect legacy manifest depedency bounds."
Right union -> pure union

Expand Down
Loading