feat(): report all violations #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poltorak
requested review from
AdrianRomanski,
BioPhoton,
Karnaukhov-kh and
rapczynska
packages/angular-mcp-server/src/lib/tools/ds/report-violations/report-violations-all.tool.ts
Outdated
Show resolved
Hide resolved
packages/angular-mcp-server/src/lib/tools/ds/report-violations/report-violations-all.tool.ts
Outdated
Show resolved
Hide resolved
poltorak
force-pushed
the
feature/find-all-violations
branch
from
ad44faa to
a58480b
Compare
|
|
||
| 1. Run a scan using the report-violations function with the following parameters: | ||
| - component: {{COMPONENT_NAME}} | ||
| 1. Run a scan using the report-all-violations function with the following parameters: |
There was a problem hiding this comment.
Primary method still remains report-violations, this should be mentioned as alternative
Comment on lines
19
to
23
| 2. Deduplicate violations by file and line: | ||
| - Process scanResult to remove duplicate entries that have the same file path and line number | ||
| - When combining duplicates, merge the component/class information (e.g., "btn, btn-primary violations on line 10") | ||
| - Keep the deduplicated count for accurate violation totals | ||
| - Store the deduplicated result and use it for all subsequent processing |
There was a problem hiding this comment.
Dedup is a bug, that should be fixed in visitor, we shouldn't mention that here.
| 2. Run a file-level scan: | ||
| - Use the report-violations function with these parameters: | ||
| - component: {{COMPONENT_NAME}} | ||
| - Use the report-all-violations function with these parameters: |
There was a problem hiding this comment.
Same, just violations is primary
Comment on lines
62
to
66
| 3. Deduplicate violations by file and line: | ||
| - Process fileScan to remove duplicate entries that have the same file path and line number | ||
| - When combining duplicates, merge the component/class information | ||
| - Keep the deduplicated count for accurate violation totals | ||
| - Store the deduplicated result and use it for all subsequent processing |
|
|
||
| 1. Run a scan using the report-violations function with the following parameters: | ||
| - component: {{COMPONENT_NAME}} | ||
| 1. Run a scan using the report-all-violations function with the following parameters: |
There was a problem hiding this comment.
Please leave current rule as is and create a separate one.
| <component_docs>{{COMPONENT_DOCS}}</component_docs>: The official documentation for the target design-system component | ||
| <component_code>{{COMPONENT_CODE}}</component_code>: The source files of the target design-system component | ||
| <usage_graph>{{USAGE_GRAPH}}</usage_graph>: A graph showing the usage of the legacy component in the specified folder | ||
| <component_docs>{{COMPONENT_DOCS}}</component_docs>: The official documentation for the target design-system components |
There was a problem hiding this comment.
Same, please keep original rule and create new one
Karnaukhov-kh
approved these changes
Aug 27, 2025
rapczynska
approved these changes
Aug 27, 2025
.cursor/flows/README.md
Outdated
| - `02-plan-refactoring.mdc` - Create detailed migration strategy for specific cases | ||
|
|
||
| **Option B: Comprehensive Approach** (recommended for large-scale migrations) | ||
| - `01a-find-all-violations.mdc` - Scan entire codebase, group by folders, select subfolder for detailed analysis |
There was a problem hiding this comment.
Option B and file name 01a. Not that critical, but inconsistent.
| - `02a-plan-refactoring-for-all-violations.mdc` - Create comprehensive migration plan for all violations in scope | ||
|
|
||
| **Continuation Steps** (used with both approaches): | ||
| - `03-non-viable-cases.mdc` - Handle non-migratable components by marking them for exclusion |
There was a problem hiding this comment.
Just noticed that we have two 03 step files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce
report-all-violations, an MCP tool that scans a directory for all Design System (DS) deprecated CSS violations across every configured DS component and outputs a consolidated report.What it does
report-violations, respectinggroupBy.Why
Changes
packages/angular-mcp-server/src/lib/tools/ds/report-violations/report-violations-all.tool.ts.loadAndValidateDsComponentsFile.analyzeProjectCoverage.formatViolations(keeps parity withreport-violations).Usage
report-all-violationsdirectory(string): directory to scangroupBy('file' | 'folder'; default: 'file')Output format
report-violations: