Use SemanticVersion.TryParse to allow all SemVer2 syntaxes#69
Open
Falco20019 wants to merge 6 commits intopushpay-labs:mainfrom
Open
Use SemanticVersion.TryParse to allow all SemVer2 syntaxes#69Falco20019 wants to merge 6 commits intopushpay-labs:mainfrom
Falco20019 wants to merge 6 commits intopushpay-labs:mainfrom
Conversation
We keep the regex to support trailers
Contributor
Author
|
Had to fix the toolchain as-well since there were some EOL things blocking the build. I would also suggest removing .NET 6 support (making it a breaking/major change) as it's EOL for some time now to also resolve the warnings for |
Contributor
Author
|
Friendly ping as this has been idle for some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep the regex to support trailers. Since
NuGet.Versioningis already a transitive dependency ofNuGet.Protocol, it was easy to do and should only be a hotfix change in my opinion. Didn't change the version yet.Fixes #68
Fixes #67