Jlo enhancements/rlhistoryreader storage order#24
Open
johannes-lode wants to merge 19 commits intopvbrowser:masterfrom
Open
Jlo enhancements/rlhistoryreader storage order#24johannes-lode wants to merge 19 commits intopvbrowser:masterfrom
johannes-lode wants to merge 19 commits intopvbrowser:masterfrom
Conversation
To avoid time calculation errors by mixing absolute time values with relative time value in the same class, the interface was changed for the application of relative amounts of time against absolute points in time. Added interface for simple formatting options of time differences.
Intermediate commit for transfer to another workstation.
Meanwhile added a proxy interface, so the traditional interface of operating with two operands of rlTimeEx is available. One small exception is there of returning double for the difference of two rlTimeEx object by default and returning rlTimeEx objects only on request by casting the second operand to RelativeTime(rltime_object).
By inspecting the logging files on logger start the data loss from deleted ring buffer files is reduced. This is achieved by avoiding the deletion of the oldest of the ring buffer files in case the youngest file is still in time window for further logging events. This way occurred a problem in Windows, where read and write pointer are not independent. So the inspection of the files and writing to the files is done from different file descriptors, opend for the special purpose. By the way reduced this problems with data logging, reopening the log files etc. after a server crash and restart.
For easier memory load the maximum reader line length can be set during construction of the reader object.
Caller of the read() method can select the storage order and thus the presentation order of the records from new to old (classic/default behavior) or from old to new (new option).
Assertions and type conversion rules ensure to combine only valid types of time (only one absolute time in addition or subtraction, all others need to be relative time values)
jlo-fixes/rltime-relative-time-adjustments Conflicts: .gitignore - resolved by mix-in rllib/lib/lib.pro - resolved by mix-in rllib/lib/rltime_v2.cpp - resolved by using my version rllib/lib/rltime_v2.h - resolved by using my version
'origin/jlo-fixes/rltime-relative-time-adjustments' into jlo-enhancements/rlhistoryreader-configure-read-line-length Conflicts: .gitignore - resolved by merging language_bindings/language_binding_rllib_wrap_lua.cxx - resolved regenerating language_bindings/lua/pvapplua/pvapplua - resolved by using incoming language_bindings/lua/pvslua/pvslua - resolved by using incoming
'origin/jlo-enhancements/rlhistoryreader-configure-read-line-length' into jlo-enhancements/rlhistoryreader-storage-order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the item order aka memory storage order in history reader configurable for new-to-old or old-to-new.
This way the items will be presented in the configured order to the user of the history reader.