-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Batzelis 2017 simple nonlinear PV model #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kandersolar
wants to merge
15
commits into
pvlib:main
Choose a base branch
from
kandersolar:batzelis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d2d4d91
add function
kandersolar c674f1b
docs
kandersolar d8988c6
tests
kandersolar e24e62f
add SDM parameter estimation and key point functions
kandersolar 994a853
lint
kandersolar 6f94408
tests for the two additional functions
kandersolar 1e61d09
whatsnew
kandersolar 7d431ab
lint
kandersolar 839d0b5
Apply suggestions from code review
kandersolar 0fde334
Merge branch 'main' into batzelis
kandersolar 55cb1eb
lint
kandersolar e641956
better handling of Rsh=np.inf
kandersolar e7ec33c
rename parameters
kandersolar 8becc1a
switch to non-normalized temp coeffs
kandersolar 006ebb0
fix whatsnew
kandersolar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer
alpha_sc
andbeta_voc
to be required in units of A/K and V/K, respectively. The parametersalpha_sc
andbeta_voc
in sdm.fit_desoto, sdm.fit_cec_sam and other function (notably, pvsystem.calcparams_desoto) use those units.Do we want the STC parameters to have the same names as in pvsystem.sapm? I'm not a fan of the SAPM names, which derive from some old spreadsheet's column headings. But they are the same quantities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Me neither.
fit_desoto
uses just the usualv_mp
etc. This PR now usesv_mp
etc. too, although those are obviously not ideal either.