- 
                Notifications
    You must be signed in to change notification settings 
- Fork 184
Adapt pysteps to allow for nowcast plugins. #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Loickemajou
  wants to merge
  22
  commits into
  master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
dgmr_plugin
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            22 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      08de598
              
                adding the dgmr model to be directly imported by pysteps.nowcasts
              
              
                Loickemajou f26bef5
              
                added the discover nowcasts and the nowcasts_info methods
              
              
                Loickemajou ab1b082
              
                added the discover nowcasts at the end so that the new nowcasts metho…
              
              
                Loickemajou 08ea3cd
              
                added the discover nowcasts and the nowcasts_info methods, to discove…
              
              
                Loickemajou bcb7ba9
              
                corrected the discover_nowcast method import
              
              
                Loickemajou 6f36867
              
                reformatted interface.py
              
              
                Loickemajou 24d6c41
              
                reformatted __init__.py
              
              
                Loickemajou 3f5d31a
              
                reformatted interface.py
              
              
                Loickemajou b37ce1d
              
                added the test for the modified nowccast interfaces
              
              
                Loickemajou cd36341
              
                adding the test for the modified nowcasts methods
              
              
                Loickemajou 0cd6aa2
              
                reformatted interface.py
              
              
                Loickemajou b9dc46d
              
                testing the modified nowcasts interface
              
              
                Loickemajou a8a401f
              
                fix some bugs in the discover nowcasts
              
              
                Loickemajou d50b78c
              
                added some test to pass the code coverage
              
              
                Loickemajou 998d076
              
                fi
              
              
                Loickemajou aa81fe8
              
                fix some bugs in the discover nowcasts
              
              
                Loickemajou 54e2dd8
              
                remove the dgmr module package
              
              
                Loickemajou 4b12402
              
                removed the dgmr in the implimented methods
              
              
                Loickemajou c063be5
              
                adding a test for the nowcast pluging discovery
              
              
                Loickemajou c790b02
              
                reformatted  __init__.py
              
              
                Loickemajou ac9f65e
              
                Remove nowcast plugin testing code. The code can be tested from the d…
              
              
                ladc 45070d4
              
                Remove debug message in discover_nowcasts(); fix comment.
              
              
                ladc File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| """Implementations of deterministic and ensemble nowcasting methods.""" | ||
|  | ||
| from pysteps.nowcasts.interface import get_method | ||
| from pysteps.nowcasts.interface import discover_nowcasts, nowcasts_info, get_method | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Loickemajou Is there a more elegant way to detect all the nowcast methods that doesn't use os.listdir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ladc, for the remark.
I will take time to look into alternative approaches and see if I can find a more elegant way to achieve this.