-
-
Notifications
You must be signed in to change notification settings - Fork 700
feat(solvers): add max_wall_time for solver timeout handling #5240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
r0hansaxena
wants to merge
7
commits into
pybamm-team:develop
Choose a base branch
from
r0hansaxena:feat/max-wall-time-timeout
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+211
−89
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
68f0954
feat(solvers): add max_wall_time for solver timeout handling
r0hansaxena f89b5c4
added changelog entry
r0hansaxena 1d10ba2
moved time import
r0hansaxena 1bdea3f
removed max_wall_time from BaseSolver init
r0hansaxena a2b1472
Implemented runtime max_wall_time timeout in BaseSolver.solve with pr…
r0hansaxena 3daebcd
added entry in the docstring for solve method
r0hansaxena aeddfcf
docstring update
r0hansaxena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.