Conversation
Allow users to set the initial state of charge directly via `EISSimulation(initial_soc=0.5)` or `solve(initial_soc=0.5)` instead of manually computing stoichiometries. Delegates to PyBaMM's `Simulation.build(initial_soc=...)` machinery. Also accepts voltage strings like "3.8 V". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Delegate initial_soc handling to PyBaMM's Simulation.build which uses eSOH fingerprinting internally, so repeated calls with the same (initial_soc, inputs) combination skip redundant rebuilds. Also pass inputs to build() so that parameters affecting capacity (e.g. active material volume fraction) are accounted for in the fingerprint. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
BradyPlanden
previously approved these changes
Mar 31, 2026
Member
BradyPlanden
left a comment
BradyPlanden
left a comment
There was a problem hiding this comment.
Thanks, just one comment on the docstring
BradyPlanden
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initial_socparameter toEISSimulation.__init__()andsolve(), accepting a float (0-1) or voltage string (e.g."3.8 V")Simulation.build(initial_soc=...)machinery, retaining the internalpybamm.Simulationobjectexamples/soc_sweep.pyby removing ~15 lines of manual stoichiometry boilerplateTest plan
test_solve_with_initial_soc— confirms different SOCs produce different impedancestest_initial_soc_in_constructor— confirms constructor and solve-time SOC give identical resultstest_initial_soc_voltage_string— confirms voltage string input works🤖 Generated with Claude Code