Conversation
These bundles include DSRC, EFC, CCC, LAC, AutonomousCharging and InfoExchange specs with dependencies, such as X509 and RFC5035. These specs were obtained from the standards.iso.org/iso/ website. The ISO 14906 DSRC ASN.1 specs sometimes use Windows code pages to encode characters in comments. I replaced them for their ASCII counterparts where I could to avoid issues.
Again, the ASN.1 specs were modified to only contain ASCII characters (even in comments).
CCC imports from DSRC specs, so they are added as dependencies
|
Thanks for the PR : this is much appreciated. I'll check the proper test integration before merging, but overall this is looking nice. |
|
Looking at the test_efc.py file, this would have been preferable to have something that integrates the automatic testing which is run during CI. Something that would be like this x509 testing, for instance: Line 2593 in 8acbc8b Do you think you could have your EFC tests implemented similar as this? |
|
Yes, I will look into the test automation ! Also, there is a patch I applied to the ISO12813(2023)EfcCccV4.1.asn specs (a new commit). I thoroughly tested CCC by switching back-and-forth T-APDUs from RSE (beacon) to OBE (device) and decoding/encoding them with CccTApdus. So far no errors! But I don't know if the patch I did was a correction or a workaround. Here go the details of my latest CCC patch... I modified it to: Most of the alterations/manipulations I did to the ASN.1 files were minimal and I believe in good faith, but it always feels weird to edit standards' documents like this... Finally, I confess I like to do rebases to edit git story and then do push -f. Since I will be editing the commit messages anyway, should I fix the ISO12813(2023)EfcCccV4.1.asn too? Or should I do a new commit? |
Hello! This is my first PR, I hope I followed the proper etiquette.
Changes
In the first 3 out of the 5 commits, I:
DSRC, EFC, CCC, LAC, AutonomousCharging, InfoExchange + dependencies (X509, RFC5035)
I then also did 2 other commits with some tests.
I added them to the test/ dir. Please tell me if this impacts the CI/CD pipeline. Should I have added my custom tests to res/ instead?
Description
For each of the 3 first commits, I:
python -m pycrate_asn1c.asnprocto recompile all the specs