Bugfix, _clean_message_history #3142
#3143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to prevent tool-return stubs from being incorrectly merged into subsequent user requests during message history cleaning. - Guard against regression introduced in commit b26a687 - Verify tool-return parts remain in separate message entries - Ensure cleaning preserves distinct message boundaries between tool results and user prompts - Validate part types remain correct after history cleaning
- Add logic to identify "stub" ModelRequests containing only ToolReturnPart or RetryPromptPart - Prevent merging non-stub requests into stub-only requests to maintain proper message structure - Allow merging stub-into-stub or non-stub-into-non-stub requests when instructions match - Refactor merge conditions for better clarity and correctness of message history handling
- Add deduplication logic to filter duplicate parts within messages - Use hash-based tracking to identify and skip duplicate content - Ensure backward compatibility with existing conversations in "bad state" - Initialize parts_set to track previously seen message parts - Append only unique parts to the final message list
This reverts commit 4746ece.
- Remove unnecessary hash-based deduplication logic that tracked parts across messages - Simplify _clean_message_history to only merge consecutive messages of same type - Remove unused import of pydantic_ai.messages module - Fix import ordering in test file to follow conventions The hash-based filtering was overly complex and potentially masking underlying issues with message construction. Message merging alone is sufficient for cleaning the history.
Add pyright ignore comment to _clean_message_history import to suppress type checking warnings for this internal API usage in the test suite.
|
Pending discussion in #3142. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3142