Improve validation error retry message #3193
Open
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
|
fine by me, should we use |
DouweM
requested changes
Oct 21, 2025
| description = f'{len(self.content)} validation errors: {json_errors.decode()}' | ||
| plural = isinstance(self.content, list) and len(self.content) != 1 | ||
| description = ( | ||
| f'{len(self.content)} validation error{"s" if plural else ""}:\n```json\n{json_errors.decode()}\n```' |
There was a problem hiding this comment.
I like using format_as_xml as Samuel suggested
|
I'd suggest we do that in a separate PR, I worry it will add a lot of tokens and hence be more debatable of an "improvement", I think this change is a bit of a no-brainer and doesn't preclude us changing to xml in the near future |
DouweM
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the rendering of the tool output when shown as markdown. Costs ~2.5% more input tokens when it's relevant, but considering this should NOT be happening frequently (if it is, you want to be tweaking your implementation to avoid retries anyway), I think the readability improvement during debugging is worth the small increase in token usage.
Before:
After:
