Add support for aspect ratio in gemini image generation #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Dec 18, 2025
| expected_size: Literal['1024x1024', '1024x1536', '1536x1024'], | ||
| ) -> None: | ||
| tool = ImageGenerationTool(aspect_ratio=aspect_ratio, size=explicit_size) | ||
| assert _resolve_openai_image_generation_size(tool) == expected_size |
Member
There was a problem hiding this comment.
@DouweM I suggest we don't include tests that import private methods. It gets hard to refactor.
Collaborator
There was a problem hiding this comment.
@Kludex I prefer not to but it's sometimes a lot easier to unit test something than to rely only on the public API surface, and I don't think this method should be public. I think of this as similar to using mocks,, not ideal but acceptable in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #3412 that has gone stale 😿
These changes will be used to complete #3599