Skip to content

Benchmarks for perf #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Benchmarks for perf #1756

wants to merge 23 commits into from
+28 −1

Conversation

ollz272
Copy link
Contributor

@ollz272 ollz272 commented Jul 17, 2025 •
edited
Loading

Change Summary

Just a quick follow up to the feature to give some benchmarks to test performance. I saw about a 3% improvement locally when building with these

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

ollz272 and others added 20 commits June 16, 2025 14:58
@ollz272
chore(deps): bump speedate to 0.16.0, make nessassary changes to code…
b3a8530 
…base
@ollz272
style: formatting
86748f7
@ollz272
fix: begin implementing ser_json_temporal
25e6ca6
@ollz272
fix: support date ser with new temporal mode
461f1e0
@ollz272
feat: implement time logic for ser_json_temporal
dce1bc5
@ollz272
Merge branch 'main' into ser_json_datetime
fe55bc8
@ollz272
fix: formatting
8194eb1
@ollz272
fix: tests
294b636
@ollz272
fix: final changes
1dbf46d
@ollz272
fix: remove redundant ok
c967da2
@ollz272
refactor: use a macro again
e6b5f82
@ollz272
fix: linting
6d28440
@ollz272
test: move tests, edit them a bit:
9bf6b8e
@ollz272
fix: implement micro second precision
2cdb4da
@ollz272
style: formatting
f856433
@ollz272
fix: rename old name
52b5799
@ollz272
fix: tidy up, docs, etc. Might be almost finished
efbd0ae
@ollz272
Merge branch 'main' into ser_json_datetime
d852a1a
@ollz272
perf: add benchmarks for new millisecond/second serialization to allo…
7f8de20 
…w it to be captured by PGO builds and track performance
@ollz272
Merge branch 'main' into benchmarks-for-perf
42cdda4
@ollz272 ollz272 marked this pull request as ready for review July 17, 2025 15:09
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1756 will not alter performance

Comparing ollz272:benchmarks-for-perf (090cd08) with main (04b296b)

Summary

✅ 157 untouched benchmarks
🆕 2 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_datetime_milliseconds N/A 25.3 µs N/A
🆕 test_datetime_seconds N/A 25.1 µs N/A

davidhewitt
davidhewitt reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the groups adjusting, otherwise lgtm, thanks!

@ollz272 ollz272 force-pushed the benchmarks-for-perf branch from a70ca0f to b8ce2be Compare July 30, 2025 05:28
@ollz272 ollz272 force-pushed the benchmarks-for-perf branch from b8ce2be to eac083b Compare July 30, 2025 05:28
@ollz272 ollz272 requested a review from davidhewitt July 30, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt Awaiting requested review from davidhewitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ollz272 @davidhewitt