Benchmarks for perf #1756
Open
Benchmarks for perf #1756
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w it to be captured by PGO builds and track performance
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1756 will degrade performances by 28.55%Comparing Summary
Benchmarks breakdown
|
davidhewitt
reviewed
Jul 23, 2025
| @@ -319,7 +319,6 @@ def r(): | |||
| fs_model_serializer.to_python(m, exclude_unset=True) | |||
|
|
|||
|
|
|||
| @pytest.mark.benchmark(group='model-list-json') | |||
There was a problem hiding this comment.
Looks like this line was unintentionally removed to the below, needs reverting
| @@ -360,6 +359,33 @@ def r(): | |||
| v.to_python(d, mode='json') | |||
|
|
|||
|
|
|||
| @pytest.mark.benchmark(group='model-list-json') | |||
There was a problem hiding this comment.
Probably the benchmark group on all these temporal tests should be adjusted, maybe group='temporal'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Just a quick follow up to the feature to give some benchmarks to test performance. I saw about a 3% improvement locally when building with these
Related issue number
Checklist
pydantic-core(except for expected changes)