Properly coerce fractions as int #1757
Open
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Jul 18, 2025
src/input/input_python.rs
Outdated
Comment on lines
288
to
291
| #[cfg(Py_3_11)] | ||
| let as_int = self.call_method0("__int__"); | ||
| #[cfg(not(Py_3_11))] | ||
| let as_int = self.call_method0("__trunc__"); |
There was a problem hiding this comment.
Not sure if there's a better way: maybe pyo3 can do the coercion directly? I've tried downcasting with no success.
CodSpeed Performance ReportMerging #1757 will not alter performanceComparing Summary
|
davidhewitt
requested changes
Jul 21, 2025
| @@ -132,6 +133,7 @@ def test_int_py_and_json(py_and_json: PyAndJson, input_value, expected): | |||
| (-i64_max + 1, -i64_max + 1), | |||
| (i64_max * 2, i64_max * 2), | |||
| (-i64_max * 2, -i64_max * 2), | |||
| (Fraction(10_935_244_710_974_505), 10_935_244_710_974_505), # https://github.com/pydantic/pydantic/issues/12063 | |||
There was a problem hiding this comment.
I think we should also test for cases when the fraction is not an exact integer, I think in those cases we should fail int validation similar to floats and decimals?
davidhewitt
approved these changes
Jul 23, 2025
Comment on lines
+288
to
+304
| #[cfg(Py_3_12)] | ||
| let is_integer = self.call_method0("is_integer")?.extract::<bool>()?; | ||
| #[cfg(not(Py_3_12))] | ||
| let is_integer = self.getattr("denominator")?.extract::<i64>().map_or(false, |d| d == 1); | ||
|
|
||
| if is_integer { | ||
| #[cfg(Py_3_11)] | ||
| let as_int = self.call_method0("__int__"); | ||
| #[cfg(not(Py_3_11))] | ||
| let as_int = self.call_method0("__trunc__"); | ||
| match as_int { | ||
| Ok(i) => Ok(EitherInt::Py(i.as_any().to_owned())), | ||
| Err(_) => break 'lax, | ||
| } | ||
| } else { | ||
| Err(ValError::new(ErrorTypeDefaults::IntFromFloat, self)) | ||
| } |
There was a problem hiding this comment.
I think it might be nice to have this as a fraction_as_int method similar to the other components here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes pydantic/pydantic#12063.
Related issue number
Checklist
pydantic-core(except for expected changes)