Correct invalid serialization of date/datetime/time/timedelta by pulling downcast checks up
#1851
+111
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
astei
force-pushed
the
astei/pull-downcast-dt-td-up
branch
from
1e8d318 to
d6cc210
Compare
pulling downcast checks up
astei
force-pushed
the
astei/pull-downcast-dt-td-up
branch
from
d6cc210 to
e5a373c
Compare
CodSpeed Performance ReportMerging #1851 will not alter performanceComparing Summary
|
astei
changed the title
date/datetime/time/timedelta by pulling instanceof checks update/datetime/time/timedelta by pulling downcast checks up
|
please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Modifies the pydantic-core serializers for
date,datetime,time, andtimedeltasuch that they perform their downcast checks first prior to performing any serialization logic. This fixes incorrect serialization with certain user-defined types and correctly emits warnings where we were incorrectly doing so ebfore.Related issue number
Fixes pydantic/pydantic#12439
Checklist
pydantic-core(except for expected changes)Selected Reviewer: @Viicos