Skip to content

Fix docstring in find_independent_seasons #10615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Aug 7, 2025

The docstring CI is failing. For some reason the repr has changed for the function find_independent_seasons used in groupers.
Just updating it seems the easiest solution.

@Illviljan Illviljan changed the title Fix docstring Fix docstring in find_independent_seasons Aug 7, 2025
@Illviljan Illviljan marked this pull request as ready for review August 7, 2025 08:31
Copy link
Contributor

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that is really weird since the doctest docs explicitly state:

NORMALIZE_WHITESPACE is especially useful when a line of expected output is very long, and you want to wrap it across multiple lines in your source.

@keewis
Copy link
Collaborator

keewis commented Aug 7, 2025

does pytest's doctest runner support NORMALIZE_WHITESPACE?

Edit: supposedly yes: https://docs.pytest.org/en/8.3.x/how-to/doctest.html#using-doctest-options

@shoyer shoyer merged commit 6ef7eed into pydata:main Aug 7, 2025
50 of 53 checks passed
@shoyer
Copy link
Member

shoyer commented Aug 7, 2025

thanks @Illviljan !

@Illviljan Illviljan deleted the doctest_independent_seasons branch August 8, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants