Skip to content

Add support for DataTree to xarray.merge() #10790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for DataTree to xarray.merge() #10790

wants to merge 3 commits into from

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Sep 25, 2025

mathause
mathause reviewed Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this! Should the path of the node be added to the error message if the merge fails?

tree1 = xr.DataTree.from_dict({"/a/b": 1})
tree2 = xr.DataTree.from_dict({"/a/b": 2})
xr.merge([tree1, tree2])

e.g. using

xarray/xarray/core/datatree_mapping.py

Line 141 in 2b947e9

def _handle_errors_with_path_context(path: str):

@veni-vidi-vici-dormivi FYI

@shoyer
Copy link
Member Author

shoyer commented Sep 26, 2025

Looking forward to this! Should the path of the node be added to the error message if the merge fails?

Great suggestion, done!

@github-actions github-actions bot added the topic-DataTree Related to the implementation of a DataTree class label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathause mathause mathause left review comments

Assignees
No one assigned
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support DataTree in xarray.merge
2 participants
@shoyer @mathause