Add Color.__bytes__

[Matiiss]

Fixes #3546

[oddbookworm]

Where docs?

[Starbuck5]

I was thinking docs aren't necessary for this change, since it makes color behave like a normal sequence would.

However I do think it would be a good idea to put a comment in the code explaining why it's necessary to have the method explicitly written out.

[oddbookworm]

I was thinking docs aren't necessary for this change, since it makes color behave like a normal sequence would.

I disagree. A versionadded note at least, that way if someone does use this functionality, they at least have some way to reference that it's broken pre-2.5.whatever

[oddbookworm]

I was thinking docs aren't necessary for this change, since it makes color behave like a normal sequence would.

I disagree. A versionadded note at least, that way if someone does use this functionality, they at least have some way to reference that it's broken pre-2.5.whatever

A user-side implementation could look like:

if pygame.version.vernum < (2, 5, 6):
    color_bytes = bytes([color.r], [color.g], [color.b], [color.a])
else:
    color_bytes = bytes(color)

[aatle]

I was thinking docs aren't necessary for this change, since it makes color behave like a normal sequence would.

I disagree. A versionadded note at least, that way if someone does use this functionality, they at least have some way to reference that it's broken pre-2.5.whatever

A user-side implementation could look like:

if pygame.version.vernum < (2, 5, 6):
    color_bytes = bytes([color.r], [color.g], [color.b], [color.a])
else:
    color_bytes = bytes(color)

Yeah, a versionadded at least.

Also that snippet doesn't work, here are two ways to convert colors currently:

bytes(list(color))
int(color).to_bytes(4)  # over 2x faster

[ankith26]

Also I'm +1 for andrews suggestion for adding this in a versionadded note. People need to know to not use this if they are targetting older pygame-ce versions

[oddbookworm]

I have a couple of comments, but I'm not so set on these that I can't be convinced otherwise if a good argument gets thrown at me

[oddbookworm]

I'm not sure this giant comment is strictly necessary in the middle of this large array definition

[oddbookworm]

I still think versionadded is more appropriate because versionchanged indicates that we changed behavior on our end, instead of overriding default python behavior by adding a new method.