refactor: use asyncio & AsyncSSH, introduce AsyncContext #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd introduce AsyncContext helper
…nd deprecation warnings for Paramiko kwargs
Fizzadar
reviewed
Oct 15, 2025
There was a problem hiding this comment.
Wow! This is incredible work, @JakkuSakura. I think moving to asyncio is definitely the way forward - I actually think we should make pyinfra's API async only and remove the complexity of having the two context types.
I still need to read through the PR in full, but generally this looks amazing, nice that the API changes aren't actually too crazy. I'd like to figure out how we can make the API accessible with minimal boilerplate, I think this is possible if we go all async.
Going to reach out (email) to figure out how we can best land this (and 4.x).
|
Glad to hear this. I'm going to use this branch in my own project to see if it causes any issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request is based on the default branch (3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)closes #1478
closes #1474