Skip to content

Fix segfault and visual glitch in client_to_desktop #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GalenYost wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix segfault and visual glitch in client_to_desktop #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions catwm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,20 +189,21 @@ void change_desktop(const Arg arg) {
}

void client_to_desktop(const Arg arg) {
client *tmp = current;
int tmp2 = current_desktop;

if(arg.i == current_desktop || current == NULL)
return;

// Add client to desktop
Window w = current->win;
int tmp2 = current_desktop;

remove_window(w);
XUnmapWindow(dis, w); // Fix visual window persistance glitch
save_desktop(tmp2); // Fix syncing issue to prevent segfault

select_desktop(arg.i);
add_window(tmp->win);
add_window(w);
save_desktop(arg.i);

// Remove client from current desktop
select_desktop(tmp2);
remove_window(current->win);

tile();
update_current();
Expand Down