feat: use ConfigGroupsEditor in GroupPresetTableWidget.#545
Merged
fdrgsp merged 7 commits intopymmcore-plus:mainfrom Apr 1, 2026
Merged
feat: use ConfigGroupsEditor in GroupPresetTableWidget.#545fdrgsp merged 7 commits intopymmcore-plus:mainfrom
fdrgsp merged 7 commits intopymmcore-plus:mainfrom
Conversation
…t and add logging for deleted config groups
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 86.89% 87.47% +0.58%
==========================================
Files 115 115
Lines 14112 14071 -41
==========================================
+ Hits 12262 12308 +46
+ Misses 1850 1763 -87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@fdrgsp, can you pull this one and try it out and merge when ready? |
Collaborator
|
@tlambert03 love it!!! Just a small thing, what if we update the example to print the changes when apply is clicked? import sys
from pymmcore_plus import CMMCorePlus
from qtpy.QtWidgets import QApplication
from pymmcore_widgets import ConfigGroupsEditor
app = QApplication([])
core = CMMCorePlus()
core.loadSystemConfiguration("tests/test_config.cfg")
with_cfg = sys.argv[1].lower() in ("1", "true") if len(sys.argv) > 1 else False
cfg = ConfigGroupsEditor.create_from_core(core, load_configs=with_cfg)
# connect to apply signal to print the changes
def _on_apply_clicked(changed, deleted, channel_group):
print("\n\nApply clicked:")
print(f"Changed: {[cg.name for cg in changed]}")
print(f"Deleted: {deleted}")
print(f"Channel group: {channel_group}")
cfg.applyRequested.connect(_on_apply_clicked)
cfg.resize(900, 550)
cfg.show()
app.exec()This way if we run |
Member
Author
|
that would be great! wanna make that change to my branch and merge when ready? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is what @fdrgsp did in the christina branch
adds the new ConfigGroupsEditor as a button to the GroupPresetTableWidget...
and adds an apply button that applies it to core ,and warns if you close without saving
closes #539
closes #540