Skip to content

SystemView: improve log messages #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobertRostohar merged 1 commit into from
Mar 31, 2026
+6 −6
Merged

SystemView: improve log messages #1944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pyocd/utility/systemview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def __init__(self, session: Session, rtt_configs: Dict[int, "RTTConfig"], system
self._files_per_core: Dict[int, List[str]] = {}

if not self._systemview.file:
LOG.debug("No SystemView output file configured; cannot configure SystemView SVDat generation")
LOG.debug("SystemView: No output file configured; cannot configure SystemView SVDat generation")
return

# Create a list of output files for each core
Expand Down Expand Up @@ -108,10 +108,10 @@ def assemble_file(self) -> bool:
try:
os.remove(f)
except OSError:
LOG.warning("Failed to remove empty SystemView file '%s'", f)
LOG.error("SystemView: failed to remove temporary empty SystemView file '%s'", f)

if not collected_files:
LOG.debug("No temporary SystemView files; skipping SVDat generation")
LOG.debug("SystemView: no temporary SystemView files; skipping SVDat generation")
return False

try:
Expand Down Expand Up @@ -146,10 +146,10 @@ def assemble_file(self) -> bool:
try:
os.remove(f)
except OSError:
LOG.warning("Failed to remove SystemView file '%s' after appending", f)
LOG.error("SystemView: failed to remove SystemView file '%s' after appending", f)
except OSError as e:
LOG.error("Failed to open/write SystemView output file '%s': %s", self._systemview.file, e)
LOG.error("SystemView: failed to open/write SystemView output file '%s': %s", self._systemview.file, e)
return False

LOG.info("SystemView SVDat file '%s' generated successfully from %d SystemView RTT channels", self._systemview.file, len(collected_files))
LOG.info("SystemView: SVDat file '%s' generated", self._systemview.file)
return True
Loading