Merged
Conversation
Collaborator
DavidLesnjak
commented
Mar 31, 2026
DavidLesnjak
commented
- set logger level to INFO after session creation when still at WARNING
- guard RTT channel setup when RTT server fails to start
- guard SystemViewSVDat initialization when no SystemView channels are configured
There was a problem hiding this comment.
Pull request overview
Updates pyocd run to behave more robustly when RTT/SystemView features are not available, and adjusts logging behavior to ensure INFO output is visible after the session is established.
Changes:
- Adjust logging level after entering the session context (when still at WARNING).
- Skip RTT channel configuration if the RTT server fails to start.
- Only initialize/assemble SystemView
.SVDatoutput when SystemView channels are actually configured.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertRostohar
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.