Conversation
There was a problem hiding this comment.
Thanks, @ryanking13! The failing test on macOS looks like an easy fix. Also, marking #58 as related (could you please check if it fully resolves the issue?)
| uv = [ | ||
| "build[uv]~=1.2.0", | ||
| ] |
There was a problem hiding this comment.
Side note; I remember that pypa/build 1.2.0 broke things for us last year. Would it be worth it for us to vendor pypa/build, so that pypabuild.py can use it instead?
There was a problem hiding this comment.
Side note; I remember that pypa/build 1.2.0 broke things for us last year.
I don't remember this. Could you please elaborate? Note that build~=1.2.0 is also set in the dependencies.
Would it be worth it for us to vendor pypa/build, so that pypabuild.py can use it instead?
No, I don't think vendoring is a good idea for pypa/build case. If we want to pin into a specific version, I would choose to pin the version in pyproject.toml instead.
There was a problem hiding this comment.
Ah, sounds good to me, thanks! It was this issue: numpy/numpy#26164
| run_prefix = ( | ||
| [uv_helper.find_uv_bin(), "run"] if uv_helper.should_use_uv() else [] | ||
| ) |
There was a problem hiding this comment.
We should be careful about this, based on https://github.com/pyodide/pyodide-build/pull/132/files#r1996940827.
There was a problem hiding this comment.
Hmm, I see. Probably, we should entirely switch from subprocess call to multiprocessing to avoid this kind of problem.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
Okay, for now I will go ahead and merge. Let's keep discuss how we can improve uv support. |
2 participants
Adds initial support for uv: make
uv run pyodide ...work. Resolve #58