DRAFT: Store library build artifacts to per-recipe directory#301
Draft
ryanking13 wants to merge 2 commits intopyodide:mainfrom
Draft
DRAFT: Store library build artifacts to per-recipe directory#301ryanking13 wants to merge 2 commits intopyodide:mainfrom
ryanking13 wants to merge 2 commits intopyodide:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the installation process for library-type recipes (static and shared libraries). The change is designed to be fully backward compatible, though it will require some integration testing to confirm.
Before:
Previously, users installed libraries directly to the
WASM_LIBRARY_DIR(by setting--prefix,CMAKE_INSTALL_PREFIX, orDESTDIR). As a result, once the build was complete, all artifacts from all libraries were merged together in a single global directory.After
Each library now installs to a local
DESTDIR—specifically, the dist/ directory inside its own build directory (similar to how Python packages are handled). Once built, pyodide-build automatically copies the artifacts from dist/ into the globalWASM_LIBRARY_DIRso they remain accessible to other packages.Motivation
This introduces two major benefits:
Artifact Isolation: It allows us to clearly distinguish and isolate the build artifacts of each individual library.
Pre-built Distribution: Because artifacts are initially stored in separate, library-specific directories, we can now bundle and release them independently. This will allow downstream packages to download and use pre-built libraries directly, bypassing the need to rebuild them from scratch.
Add changelog entry
Run integration tests at pyodide-recipes