Conversation
evenharder
left a comment
There was a problem hiding this comment.
Thank you for your constructive work! I have also previously tried to convert it in my local, and the results are fairly similar. There are some minor comments I want to address.
| base_path, | ||
| wheel_url, | ||
| ): | ||
| """Add a set of package wheels to an existing pyodide-lock.json and |
There was a problem hiding this comment.
Arguments are not printed by default in click. If we were to provide consistency, we can explicitly add argument info in the docstring by appending
\b
Arguments:
WHEELS: List of paths to wheel files. (required)
or something similar.
There was a problem hiding this comment.
I see. Thanks for the pointer!
| @click.option( | ||
| "--base-path", | ||
| type=click.Path(path_type=Path), | ||
| default=None, |
There was a problem hiding this comment.
Is None accepted as click.Path? As typer version worked well, it will do so, but I am slightly concerned about its behavior.
There was a problem hiding this comment.
I think it does. I believe click will not change the None to something else, and it should be fine then.
| assert "needs-one-opt" in example_lock_spec.packages | ||
| assert example_lock_spec.packages["needs-one-opt"].file_name.startswith( | ||
| "http://www.nowhere.org/dist/nEEds" | ||
| "http://www.nowhere.org/dist/needs" |
There was a problem hiding this comment.
I wonder why it was written with nEEds in the first place, it should have been intentional?
There was a problem hiding this comment.
probably to test name canonicalization
There was a problem hiding this comment.
I am not sure why the original test was written with nEEds and why it passed. The filename should be canonicalized I gueess.
|
Love removing deps, but why not go all the way and use |
Well, we would like to integrate different tools in a single |
Thanks. I hope my work didn't conflict with yours. I was trying to improve our build system and wanted to push this forward. If you are working on other packages, please let me know. |
Drops typer dependency
cc: @evenharder