Skip to content

Add coolname package#485

Open
jolaf wants to merge 3 commits intopyodide:mainfrom
jolaf:coolname
Open

Add coolname package#485
jolaf wants to merge 3 commits intopyodide:mainfrom
jolaf:coolname

Conversation

@jolaf
Copy link
Copy Markdown

@jolaf jolaf commented Jan 21, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 21, 2026

Package Build Results

Total packages built: 28
Total build time: 0:02:36

Package Build Times (click to expand)
Package Build Time
libopenssl 2m 32s
sqlite3 1m 11s
liblzma 1m 1s
test 24s
regex 12s
MarkupSafe 4s
pydoc_data 4s
lzma 4s
ssl 4s
atomicwrites 3s
pydecimal 3s
hashlib 3s
Jinja2 1s
pluggy 1s
tblib 1s
pyparsing 1s
py 1s
coolname 1s
pytz 1s
iniconfig 1s
attrs 1s
more-itertools 1s
setuptools 1s
micropip 1s
exceptiongroup 1s
pytest 0s
pytest-asyncio 0s
six 0s

Longest build: libopenssl (2m 32s)
Packages built in more than 10 minutes: 0

Copy link
Copy Markdown
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jolaf, thanks for adding a recipe for coolname! This is a good start. Could you please add some tests? You may look at how other packages have their tests set up next to their recipe files, but the idea is that we want to have a few basic checks that the package is importable, and rudimentary parts of its functionality work as expected and run in our CI.

@jolaf
Copy link
Copy Markdown
Author

jolaf commented Jan 23, 2026

Could you please add some tests?

Done.

@jolaf jolaf requested a review from agriyakhetarpal January 23, 2026 15:36
Copy link
Copy Markdown
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jolaf! LGTM!

Copy link
Copy Markdown
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolname is a pure python package that you can already install with micropip.install. Could you please explain why do you want to include this into Pyodide distribution explicitly? Regarding that you said you don't want to maintain the recipe, we would need a proper reason why this needs to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants