Conversation
Package Build ResultsTotal packages built: 28 Package Build Times (click to expand)
Longest build: libopenssl (2m 32s) |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Hi @jolaf, thanks for adding a recipe for coolname! This is a good start. Could you please add some tests? You may look at how other packages have their tests set up next to their recipe files, but the idea is that we want to have a few basic checks that the package is importable, and rudimentary parts of its functionality work as expected and run in our CI.
Done. |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @jolaf! LGTM!
ryanking13
left a comment
There was a problem hiding this comment.
Coolname is a pure python package that you can already install with micropip.install. Could you please explain why do you want to include this into Pyodide distribution explicitly? Regarding that you said you don't want to maintain the recipe, we would need a proper reason why this needs to be added.
No description provided.