.github/workflows/build.yml: Upload artifacts also on failing builds#504
Draft
mkoeppe wants to merge 1 commit intopyodide:mainfrom
Draft
.github/workflows/build.yml: Upload artifacts also on failing builds#504mkoeppe wants to merge 1 commit intopyodide:mainfrom
mkoeppe wants to merge 1 commit intopyodide:mainfrom
Conversation
ryanking13
requested changes
Feb 16, 2026
Member
ryanking13
left a comment
ryanking13
left a comment
There was a problem hiding this comment.
Sound reasonable, but the build logs are not copied to build-logs directory unless the build succeeds, so this PR will not work. I guess we need to the behavior of pyodide-build first to make this work.
| PR_NUMBER: ${{ github.event.number }} | ||
| run: | | ||
| if [ -f result/build_output.log ]; then | ||
| python tools/parse_build_result.py result/build_output.log > result/build_summary.md |
Member
There was a problem hiding this comment.
This script does not handle build failure. If it is for debugging, running this script won't be very useful.
| echo ${PR_NUMBER} > result/pr_number | ||
|
|
||
| - name: Compress build artifacts | ||
| if: always() |
Member
There was a problem hiding this comment.
repodata directory will not contain any wheels on build failure.
|
|
||
| - name: Store build logs | ||
| uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | ||
| if: always() |
Member
There was a problem hiding this comment.
Logs are also copied after the build succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... for inspection when builds fail