Conversation
|
This is interesting. It works on a Chrome browser which we tested yet fails here in the Chrome tests (Firefox tests and node passed). The error suggests that the core.so file at 22MB is too large to be loaded synchronously on Chrome so Claude now converted it to a dynlib so it can be loaded by pyodide asynchronously. To do that it had to split rdkit into rdkit and librdkit packages. Let's see if it's all in its imagination by running the tests here :P |
|
Works now! I'll try one more thing to simplify the linking |
Package Build ResultsTotal packages built: 24 Package Build Times (click to expand)
Longest build: librdkit (49m 41s) |
|
Ok, it's good to go now |
Thanks for working on this! The PR looks good overall, but what I am concerned is the Regarding you and @fxcoudert were discussing this in rdkit repository (rdkit/rdkit#7827), would you be possible to upstream this change to rdkit itself; i.e. building WASM version in rdkit CI, and only add the built wheel here? For instance, we are doing the same thing for duckdb. It is built in a separate repository so that we don't need to rebuild it everytime. |

Added the rdkit package with tests. I tested it a decent bit and it seems to work fine.
For transparency, this is 99% 🤖-generated code with Claude, I mostly intervened to keep it in line with our requirements and asking it to simplify things.
These are probably the only missing features compared to the full RDKit PyPI build: