Open
Conversation
Member
|
It looks like skipping (host) numpy installation is not working after this change, resulting in scipy build error. |
Member
Author
|
Hmm I tried building scipy locally and it worked fine... |
See upstream PR: pyodide/pyodide-build#60 Resolves pyodide#5187. In that issue, the build requires a package called `cmake-build-extension` but because we have `cmake` in the list of requirements to avoid we drop it and it breaks the build. This logic was introduced in pyodide#2272 and did not come up in the review. Surprisingly this is the first problem it has caused. Let's see if this change breaks anything in Pyodide CI.
hoodmane
force-pushed
the
less-sloppy-remove-avoided-reqs
branch
from
721ba9f to
81e2441
Compare
agriyakhetarpal
force-pushed
the
less-sloppy-remove-avoided-reqs
branch
from
72c87e0 to
51ffae8
Compare
Member
|
I updated the submodule to point to pyodide/pyodide-build#60 again in the previous commit, as we no longer include CMake as a part of avoided build-time requirements. |
Member
|
Actually, if |
2 tasks
Member
|
I am having the statsmodels build issue in pyodide-recipes PR as well. It uses tot pyodide-build, so I think it is not related to pyodide/pyodide-build#60. Maybe there was other regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See upstream PR:
pyodide/pyodide-build#60
Resolves #5187. In that issue, the build requires a package called
cmake-build-extensionbut because we havecmakein the list of requirements to avoid we drop it and it breaks the build.This logic was introduced in #2272 and did not come up in the review. Surprisingly this is the first problem it has caused. Let's see if this change breaks anything in Pyodide CI.