Skip to content

[WIP] Moved MarkerData.values init to base class.#85

Open
oguzhanlt wants to merge 1 commit intopyomeca:mainfrom
oguzhanlt:fix/remove-markerdata-values
Open

[WIP] Moved MarkerData.values init to base class.#85
oguzhanlt wants to merge 1 commit intopyomeca:mainfrom
oguzhanlt:fix/remove-markerdata-values

Conversation

@oguzhanlt
Copy link
Copy Markdown

@oguzhanlt oguzhanlt commented Jan 8, 2026

Should resolve #79.

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @EveCharbie in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

@oguzhanlt
Copy link
Copy Markdown
Author

PR is ready for review. @EveCharbie. Please let me know if you meant a deeper change for .values.

@EveCharbie
Copy link
Copy Markdown
Collaborator

Thanks for this !
It seems like you are out of sync with the main branch, which is why addressing issue #79 feels weird.
Could you please merge pyomeca/main in your branch and resolve the conflicts if any ?
Then, you will see appear other classes inheriting from MarkerData, they should all be undated (C3dData, CsvData, DictData)

@oguzhanlt
Copy link
Copy Markdown
Author

Oh yes I only realized now. I will pull the changes and see if it still applies or maybe if I can do more. Thanks for pointing it out!

@oguzhanlt oguzhanlt changed the title [RTR] Moved MarkerData.values init to base class. [WIP] Moved MarkerData.values init to base class. Jan 9, 2026
@EveCharbie
Copy link
Copy Markdown
Collaborator

Hi :)
Are you still working on this PR ?

@oguzhanlt
Copy link
Copy Markdown
Author

Hi!,
I could not find so much time since then, but yes I plan to work on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ".values" from MarkerData classes

2 participants